Fix bare except clauses to catch specific exceptions#23
Merged
cgiovanetti merged 1 commit intomainfrom Jan 26, 2026
Merged
Conversation
Bare `except:` clauses catch ALL exceptions including KeyboardInterrupt, SystemExit, and programming errors like NameError or AttributeError. This can mask bugs silently. Changed all bare `except:` to `except (RuntimeError, IndexError):` in: - linx/thermo.py:674 - linx/weak_rates.py:105 and :122 - linx/reactions.py:152 These exceptions are the ones actually expected when GPU is unavailable (RuntimeError for no GPU backend, IndexError for empty device list). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical Issue
Bare
except:clauses catch ALL exceptions, including:KeyboardInterrupt(user pressing Ctrl+C)SystemExit(program exit)NameError,AttributeError(programming bugs)This is dangerous because it silently masks bugs. For example, the typo
mu_media_vecinstead ofmu_median_vecinreactions.py:147was being silently swallowed by the bareexcept:at line 152 — the code appeared to work but GPU placement was silently failing.Fix
Changed all bare
except:toexcept (RuntimeError, IndexError):which are the specific exceptions expected when:Files Changed
linx/thermo.pyexcept:→except (RuntimeError, IndexError):linx/weak_rates.pyexcept:→except (RuntimeError, IndexError):linx/weak_rates.pyexcept:→except (RuntimeError, IndexError):linx/reactions.pyexcept:→except (RuntimeError, IndexError):Test plan
pytest pytest/🤖 Generated with Claude Code